-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SimpleReach measurement #2055
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
CLAs look good, thanks! |
Ping for @avimehta @rudygalfi |
LGTM. @avimehta Can you take a look, too? |
|
||
Type attribute value: `simplereach` | ||
|
||
Adds support for SimpleReach. Configuration details can be found at [simplereach.com/docs](http://docs.simplereach.com/dev-guide/implementation/google-amp-implementation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://docs.simplereach.com/dev-guide/implementation/google-amp-implementation appears to be an empty page. What's your timeline for publishing something there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can deploy that page as early as tomorrow. You can view the staging version here: http://docs.staging-001.simplereach.com.s3-website-us-east-1.amazonaws.com/dev-guide/implementation/google-amp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM, thanks!
Just one more comment on the documentation page. After that, I'm willing to LGTM and merge. |
Add support for SimpleReach measurement
See #1511 for more information.