Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SimpleReach measurement #2055

Merged
merged 1 commit into from
Feb 19, 2016

Conversation

devdazed
Copy link

See #1511 for more information.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

@devdazed devdazed changed the title Add support for SimpleReach measurment Add support for SimpleReach measurement Feb 17, 2016
@cramforce
Copy link
Member

Ping for @avimehta @rudygalfi

@rudygalfi
Copy link
Contributor

LGTM. @avimehta Can you take a look, too?


Type attribute value: `simplereach`

Adds support for SimpleReach. Configuration details can be found at [simplereach.com/docs](http://docs.simplereach.com/dev-guide/implementation/google-amp-implementation)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://docs.simplereach.com/dev-guide/implementation/google-amp-implementation appears to be an empty page. What's your timeline for publishing something there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can deploy that page as early as tomorrow. You can view the staging version here: http://docs.staging-001.simplereach.com.s3-website-us-east-1.amazonaws.com/dev-guide/implementation/google-amp

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thanks!

@rudygalfi
Copy link
Contributor

Just one more comment on the documentation page. After that, I'm willing to LGTM and merge.

rudygalfi added a commit that referenced this pull request Feb 19, 2016
Add support for SimpleReach measurement
@rudygalfi rudygalfi merged commit d977710 into ampproject:master Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants