INFOnline iframe embed must be on publisher domain #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -370,6 +370,8 @@ export class AmpAnalytics extends AMP.BaseElement { | |||
| if (trigger['iframePing']) { | |||
| assert(trigger['on'] == 'visible', | |||
| 'iframePing is only available on page view requests.'); | |||
| // enable passing urls via vars | |||
| request = decodeURIComponent(request); | |||
There was a problem hiding this comment.
This isn't the right way to do it, please remove here.
sebastianbenz
force-pushed
the
infonline
branch
from
76d1b46 to
d6badc1
Compare
|
PTAL |
|
LGTM if it works :) |
|
Works on my machine ;-) |
cramforce
added a commit
that referenced
this pull request
Feb 16, 2016
INFOnline iframe embed must be on publisher domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analytics request referer must come from the publisher's domain.