feature(viewer): read csi from viewer params
#2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we'd want to merge this after the viewer already has the new param since i set the default to be "off" (which we can reverse of course) |
| @@ -194,7 +194,8 @@ | |||
| paddingTop: this.header./*OK*/offsetHeight, | |||
| visibilityState: this.visibilityState_, | |||
| prerenderSize: this.prerenderSize_, | |||
| viewerorigin: parseUrl(window.location.href).origin | |||
| viewerorigin: parseUrl(window.location.href).origin, | |||
| csi: 0 | |||
There was a problem hiding this comment.
lets call this property performanceTracking. At least on our side.
There was a problem hiding this comment.
done.
added some additional code in performance.js to ignore all ticks and flush calls when performanceTracking is off.
|
LGTM with one style comment |
erwinmombay
force-pushed
the
csi-off
branch
2 times, most recently
from
4b51b95 to
e06b34e
Compare
erwinmombay
added a commit
that referenced
this pull request
Feb 19, 2016
feature(viewer): read `csi` from viewer params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.