Actually enforce what error message says: Protocol relative only allowed when container is HTTPS. #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @return {string} | ||
| */ | ||
| export function assertHttpsUrl(urlString, elementContext) { | ||
| export function assertHttpsUrl(urlString, elementContext, opt_win) { |
There was a problem hiding this comment.
Will we actually ever supply opt_win? It seems a bit odd, given that all URLs are resolved against the current window in the line above parseUrl(urlString). Or is it only for tests?
There was a problem hiding this comment.
Its only for tests. But your comment is correct. This was wrong in different way from what I thought.
There was a problem hiding this comment.
Are you thinking about changing this? You could also rename it to opt_winForTestOnly or something like that.
There was a problem hiding this comment.
I'll need to do something entirely different for this change :)
cramforce
force-pushed
the
https-check
branch
from
800d2c1 to
a307b62
Compare
…wed when container is HTTPS. Fixes ampproject#2027
cramforce
force-pushed
the
https-check
branch
from
a307b62 to
22932de
Compare
|
PTAL. New fix just deletes a line. |
|
LGTM |
cramforce
added a commit
that referenced
this pull request
Feb 16, 2016
Actually enforce what error message says: Protocol relative only allowed when container is HTTPS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2027