Add special whitelisted iframe ping transport. #1993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
force-pushed
the
iframe-ping
branch
from
05ad33b to
6b53cc7
Compare
| if (to === null || to === undefined) { | ||
| to = {}; | ||
| } | ||
|
|
||
| for (const property in from) { | ||
| assert(opt_predefinedConfig || property != 'iframePing', | ||
| 'iframePing config is only available to vendor config.'); |
There was a problem hiding this comment.
Not sure putting a specific error message in a generic function is a good idea.
|
Added a note, LGTM otherwise |
|
lgtm. |
This allows analytics vendors to transition into amp-analytics before they are ready to fully use it. It only works for page view pings and cannot be used from customer configs.
cramforce
force-pushed
the
iframe-ping
branch
from
6b53cc7 to
7c22eda
Compare
cramforce
added a commit
that referenced
this pull request
Feb 13, 2016
Add special whitelisted iframe ping transport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows analytics vendors to transition into amp-analytics before they are ready to fully use it.
It only works for page view pings and cannot be used from customer configs.