RFC: Authorization fallback #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2016
Closed
dvoytenko
added
NEEDS REVIEW
WG: access-subscriptions
and removed
Type: Discussion/Question
labels
|
@cramforce This is now ready for review. PTAL. |
| @@ -350,6 +352,16 @@ export class AccessService { | |||
| credentials: 'include', | |||
| requireAmpResponseSourceOrigin: true | |||
| })); | |||
| }).catch(error => { | |||
| this.analyticsEvent_('access-authorization-failed'); | |||
There was a problem hiding this comment.
Please write a test for this.
There was a problem hiding this comment.
Yes. Working on tests still as specified above. Will be available soon.
dvoytenko
force-pushed
the
access38
branch
2 times, most recently
from
6e527df to
a7b0d4a
Compare
|
@cramforce PTAL. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1906.
(No tests yet)
This RFC item proposes to add an optional "authorizationFallback" configuration property that will be used in case when the authorization fails.
/cc @jugglingcats, @ashwinlimaye, @sebastianbenz, @andreban