Validator roll-up. #1955
Merged
Validator roll-up. #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diff: Disallow http on any tags inside <noscript>: img, audio>source. Allow http on tags which amp runtime can fix: amp-youtube, amp-instagram, amp-vimeo Disallow http on amp-analytics, amp-audio, amp-audio>source. Allow data on amp-iframe, img. Allow tel protocol on a[href].
Validate URLs are not missing for srcset attributes Validate URLs in srcsets are valid (via goog.Uri.parse) Validate protocols are allowed in srcset attributes amp-img's srcset: data, http, https amp-anim's srcset: data, http, https img's srcset: http, https
This should pacify the ampproject presubmits.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
@googlebot I confirm. |
|
@googlebot I confirm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks allowed protocols, validates URLs in srcset, schema.org attributes.