Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flakey Travis Dyanmic-CSS-Classes #1924

Merged
merged 2 commits into from
Feb 11, 2016

Conversation

jridgewell
Copy link
Contributor

Reverts #1909, which is causing the flake. Also reverts #1922 which disabled the tests.

@jridgewell jridgewell force-pushed the travis-dynamic-css-flake branch 4 times, most recently from 108b68b to 6b96eb5 Compare February 11, 2016 02:18
…htcove-params"

This reverts commit 14ff6eb, reversing
changes made to db7e7cb.
…doo-da"

This reverts commit 66b5274, reversing
changes made to 63f786b.
@jridgewell jridgewell force-pushed the travis-dynamic-css-flake branch from 6b96eb5 to 8b7f8d8 Compare February 11, 2016 02:26
@jridgewell jridgewell changed the title [DO NOT SUBMIT] Debugging Travis Dyanmic-CSS-Classes Flake Fix Flakey Travis Dyanmic-CSS-Classes Feb 11, 2016
@erwinmombay
Copy link
Member

@jridgewell LGTM

@cramforce
Copy link
Member

@mister-ben We had to revert your last change. We don't know why, but it causes unrelated tests to fail.

cramforce added a commit that referenced this pull request Feb 11, 2016
@cramforce cramforce merged commit e968efa into ampproject:master Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants