Propagate analytics events in access: events and NO data

[dvoytenko]

/cc @avimehta

[cramforce]

Its mandatory to exist, right?

[dvoytenko]

Correct.

[cramforce]

This looks great.

Regarding docs. Maybe this should live with access docs?

The docs here https://github.com/ampproject/amphtml/blob/master/extensions/amp-analytics/amp-analytics.md#triggers need a rework I think @rudygalfi. The available events should probably get their own heading.

[rudygalfi]

@cramforce Revised doc: #1897

[dvoytenko]

@cramforce @rudygalfi Alright. I will add docs in the access spec and make references from analytics docs there.

[rudygalfi]

Sorry, forgot to give my take on the docs question.

TL;DR: Agree with putting this in the access docs but may have further feedback on location once there's a draft to review.

I definitely think we should consolidate the key points regarding analytics for access in the access docs. That way it's discoverable by the people who are using the access solution. I think this would cover topics like the new trigger types and AUTHDATA variable. There may be other things.

I would also recommend incorporating documentation into the amp-analytics.md and substitutions files for completeness. It doesn't need to cover these things in depth. We could link off to the access docs to do that. It's a bit hard to suggest exactly how this should be handled, so I'd recommend preparing docs mainly in the access docs as you suggest @dvoytenko and we can discuss further in the review stages.

[dvoytenko]

@cramforce @rudygalfi I added amp-access-analytics.md docs file and linked it from the access and analytics specs. PTAL.

One question: I'm wondering if we should get rid of the amp- prefix in all the events.

[cramforce]

LGTM