Expose richer visibility APIs to AMP ads. #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
force-pushed
the
invisibility-and-viewability
branch
from
00c9666 to
b0ec7de
Compare
| @@ -268,6 +268,9 @@ export function installAd(win) { | |||
| this.iframe_.style.visibility = ''; | |||
| this.sendEmbedInfo_(this.isInViewport()); | |||
| }, /* opt_is3P */ true); | |||
| viewerFor(this.getWin()).onVisibilityChanged(() => { | |||
There was a problem hiding this comment.
make this
this.viewer_ = viewerFor(this.getWin()); (or a local const)
There was a problem hiding this comment.
Not generally necessary, but since there were now 3 of these in the file I cleaned it up.
|
LG except for a nit. |
cramforce
force-pushed
the
invisibility-and-viewability
branch
from
b0ec7de to
1ac78de
Compare
cramforce
added a commit
that referenced
this pull request
Feb 8, 2016
Expose richer visibility APIs to AMP ads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1838
Fixes #1826