Enable retrieving amp-analytics remote config with credentials. #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let fetchConfig = { | ||
| requireAmpResponseSourceOrigin: true, | ||
| }; | ||
| if (this.element.hasAttribute('data-include-credentials')) { |
There was a problem hiding this comment.
In amp-list, we do credentials=include, so maybe here, let's do data-credentials=include?
|
Few comments, but otherwise LGTM |
cramforce
force-pushed
the
analytics-config
branch
from
285438b to
f20b1c4
Compare
Also starts mandating AMP CORS protocol for credentialed requests to amp-list. Verified that the guardian is currently not including credentials in their requests.
cramforce
force-pushed
the
analytics-config
branch
from
f20b1c4 to
fe5f740
Compare
cramforce
added a commit
that referenced
this pull request
Feb 5, 2016
Enable retrieving amp-analytics remote config with credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also starts mandating AMP CORS protocol for credentialed requests to amp-list.
Verified that the guardian is currently not including credentials in their requests.