Tunes ad loading heuristic. #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
force-pushed
the
ad-heuristics
branch
from
6ef8a44 to
195a3d2
Compare
We now load out of viewport ads before initial scrolling. Given recent performance improvements this seems a better trade off for UX, as ads below initial viewport are more likely to be done.
cramforce
force-pushed
the
ad-heuristics
branch
from
195a3d2 to
d935d98
Compare
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now load out of viewport ads before initial scrolling. Given recent performance improvements this seems a better trade off for UX, as ads below initial viewport are more likely to be done.
Also puts
amp-analyticson the same priority asamp-pixel.