Pass source origin in all fetch requests #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvoytenko looks good to me, passing onto @cramforce |
| const url = parseUrl(input); | ||
| const queryString = parseQueryString(url.search); | ||
| const querySourceOrigin = queryString[SOURCE_ORIGIN_PARAM]; | ||
| if (!querySourceOrigin) { |
There was a problem hiding this comment.
if (SOURCE_ORIGIN_PARAM in queryString) {
throw …
}
|
@cramforce I've addressed the comments. And I also added the check for |
| const url = parseUrl(input); | ||
| const query = parseQueryString(url.search); | ||
| if (SOURCE_ORIGIN_PARAM in query || | ||
| decodeURI(input).indexOf(SOURCE_ORIGIN_PARAM) != -1) { |
|
LGTM with one comment |
dvoytenko
force-pushed
the
access28
branch
2 times, most recently
from
2b5b294 to
d6df7c4
Compare
dvoytenko
added a commit
that referenced
this pull request
Feb 5, 2016
Pass source origin in all fetch requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1762.