Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement <amp-ad type="adform"> support #1758

Merged
merged 1 commit into from
Feb 4, 2016
Merged

Implement <amp-ad type="adform"> support #1758

merged 1 commit into from
Feb 4, 2016

Conversation

simast
Copy link

@simast simast commented Feb 3, 2016

This PR adds Adform ad support to <amp-ad> tag.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

for (const type in hosts) {

try {
validateSrcPrefix(hosts[type], src);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind instead changing validateSrcPrefix to take an array of prefixes? And add some unit tests there?

@cramforce
Copy link
Member

This looks excellent! Thanks! I added a few comments.

@cramforce
Copy link
Member

Please rebase. I changed the amp-ad docs around a bit.

@cramforce cramforce self-assigned this Feb 4, 2016
@simast
Copy link
Author

simast commented Feb 4, 2016

@cramforce: Squashed and updated per your comments!

@cramforce
Copy link
Member

Excellent! LGTM

cramforce added a commit that referenced this pull request Feb 4, 2016
Implement <amp-ad type="adform"> support
@cramforce cramforce merged commit ef05c50 into ampproject:master Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants