Fix several bugs in CSI collection #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.tick('pc', undefined, userPerceivedVisualCompletenesssTime); | ||
| const userPerceivedVisualCompletenesssTime = docVisibleTime > -1 | ||
| ? (timer.now() - docVisibleTime) | ||
| : 1 /* MS (magic number for prerender was complete |
There was a problem hiding this comment.
csi doesnt like 0 im guessing?
There was a problem hiding this comment.
ah nvm, i get it (we already use 0 in tickDelta) and we use 1 as the relative time to it. (for no user perceived delay)
|
@cramforce LGTM besides the 1 question of about lazy init of promise for |
- miunderstanding of API: To tick absolute deltas one needs to use the relative tick feature with an awkward call pattern. Added `tickDelta` method to make that less weird. - the pc-tick never fired if the layout promises had already started by the time we started measuring 1st viewport performance. Instead added a simpler `loaded` promise to each resource that can always be subscribed to.
| @@ -1348,6 +1348,9 @@ export class Resource { | |||
| /** @private {boolean} */ | |||
| this.isInViewport_ = false; | |||
|
|
|||
| /** @private {?Promise<undefined>} */ | |||
| this.layoutPromise_ = null; | |||
|
LGTM from me. |
cramforce
added a commit
that referenced
this pull request
Feb 2, 2016
Fix several bugs in CSI collection
|
@cramforce guessing you want this released into prod asap? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tickDeltamethod to make that less weird.loadedpromise to each resource that can always be subscribed to.