amp-list: [src] mutation must be in mutate context #16513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16513 +/- ##
==========================================
- Coverage 78.07% 78.07% -0.01%
==========================================
Files 549 549
Lines 40067 40089 +22
==========================================
+ Hits 31283 31300 +17
- Misses 8784 8789 +5
Continue to review full report at Codecov.
|
|
/to @aghassemi |
aghassemi
reviewed
Jul 2, 2018
extensions/amp-list/0.1/amp-list.js
Outdated
| this.attemptChangeHeight(scrollHeight).catch(() => {}); | ||
| } | ||
| }); | ||
| if (mutate) { |
There was a problem hiding this comment.
Can we always do it in mutate block? Every amp-list render is async anyway.
There was a problem hiding this comment.
A frame or two slower, but a lot easier to follow. 👍
aghassemi
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16502.