-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new validator tools subfolder and doc for building a command-line validator on Mac OS X #1554
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it
|
|
||
``` | ||
$ brew install node | ||
$ sudo npm install -g lodash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably avoid the -g
here. If you have a package.json local installation should work.
Could you also update and point to your new doc in https://github.com/ampproject/amphtml/blob/master/validator/README.md |
Would it make sense to call this new directory docs instead of tools? |
Done: |
$ brew install node | ||
``` | ||
|
||
### Edit /etc/hosts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to drop this section since it's not needed for the validator. We have a DEVELOPMENT.md with these instructions instead.
Sweet, thank you! I think this is good to go, except I see very many commits in this PR. Would you mind squashing these so the overall change history for the project is easier to read? You may already know how to do this, but in case not, this doc has helped me in the past: |
Squash done as follows (although authentication for terminal git push fails - 2 factor auth maybe?): commit 63bedbb679e6ef6659bae5595a4d58d2a44df5b5
|
Forced push using 2F token over https:
|
Hmm, I wonder whether something went wrong. Now I see a bunch of different files in there (https://github.com/ampproject/amphtml/pull/1554/files - 9 total). :-( |
Yep, only the last 3 are mine: |
Thank you! @jridgewell I think the comment about the /etc/hosts makes sense but a link to the development.md can go in as a follow up as well, so I think this one is fine as is. |
Add new validator tools subfolder and doc for building a command-line validator on Mac OS X
Add new validator tools subfolder and doc for how to build the official AMP-HTML command-line AMP validator on Mac OS X.