remove amp-user-notification from experiment #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
remove-from-canary
branch
from
7920478 to
8eba195
Compare
erwinmombay
changed the title
erwinmombay
force-pushed
the
remove-from-canary
branch
from
8eba195 to
ffdb1c1
Compare
|
meant remove from experiment* (not canary) |
|
LGTM |
| * @private | ||
| */ | ||
| isExperimentOn_() { | ||
| return isExperimentOn(this.getWin(), EXPERIMENT); |
There was a problem hiding this comment.
EXPERIMENT should be removed as well, right?
There was a problem hiding this comment.
@dvoytenko yep! linter caught it too, thanks!
|
LGTM with a small comment. |
erwinmombay
force-pushed
the
remove-from-canary
branch
2 times, most recently
from
421ade5 to
87a13cb
Compare
erwinmombay
added a commit
that referenced
this pull request
Jan 21, 2016
remove amp-user-notification from experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.