Delay unhiding body until Dynamic CSS is loaded #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function installDynamicClassesService(win) { | ||
| return getService(win, 'dynamic-css-classes', () => { | ||
| addRuntimeClasses(win); | ||
| return {}; |
|
Very nice! |
|
You didn't catch my Easter egg, though. Have an idea what to name the file? |
| @@ -0,0 +1,36 @@ | |||
| /** | |||
There was a problem hiding this comment.
Name the file render-delaying-extensions.js.
|
LGTM, but please add the timeout to |
jridgewell
force-pushed
the
dynamic-css-classes-delay-body
branch
3 times, most recently
from
68049da to
68e6786
Compare
This will allow me to add a Dynamic CSS promise without exporting a custom element.
- Fixes issue with `useCompiledJS` on the debug page - Adds `opacity` checks to `#hidden` and `#visible` matchers
jridgewell
force-pushed
the
dynamic-css-classes-delay-body
branch
2 times, most recently
from
6b37e03 to
3dd3bc9
Compare
But only if we’ve included the extension.
jridgewell
force-pushed
the
dynamic-css-classes-delay-body
branch
from
3dd3bc9 to
3ce05ca
Compare
|
PTAL |
|
LGTM |
jridgewell
added a commit
that referenced
this pull request
Jan 20, 2016
Delay unhiding body until Dynamic CSS is loaded
This was referenced Jan 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But only if we’ve included the extension.
Also included:
useCompiledJSon the debug pageopacitychecks to#hiddenand#visiblematchers