JS Error body unhide should also support new boilerplate #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,7 +123,10 @@ function compile(watch, shouldMinify) { | |||
| // If there is a sync JS error during initial load, | |||
| // at least try to unhide the body. | |||
| wrapper: 'try{<%= contents %>}catch(e){setTimeout(function(){' + | |||
| 'document.body.style.opacity=1},1000);throw e};' | |||
| 'document.body.style.opacity=1;' + | |||
There was a problem hiding this comment.
Please make a little var like:
var s=document.body.style; and then use it.
|
Please check out the test error. |
camelburrito
force-pushed
the
bpbug
branch
2 times, most recently
from
1409cc2 to
1269cb6
Compare
|
PTAL |
camelburrito
force-pushed
the
bpbug
branch
2 times, most recently
from
3efba70 to
828c60b
Compare
|
PTAL |
|
LGTM |
|
LGTM |
camelburrito
pushed a commit
that referenced
this pull request
Jan 22, 2016
JS Error body unhide should also support new boilerplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1414