Standard action to hide elements #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,60 @@ | |||
| /** | |||
| * Copyright 2015 The AMP HTML Authors. All Rights Reserved. | |||
|
@dvoytenko LGTM. (per minor nits) |
| @@ -189,10 +189,11 @@ <h1 itemprop="headline">Lorem Ipsum</h1> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <section amp-access="views > 0" amp-access-hide class="meter-section"> | |||
| <section id="meter-notif" amp-access="views > 0" amp-access-hide class="meter-section"> | |||
| <template amp-access-template type="amp-mustache"> | |||
| You are viewing article {{views}} of {{maxViews}}! | |||
There was a problem hiding this comment.
Nit for complete example: if views > maxViews it can say "You have read your {{maxViews}} free articles. Please login to read more"
dvoytenko
added a commit
that referenced
this pull request
Jan 15, 2016
Standard action to hide elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.