Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DoubleClick ads to explicitly request an ad size. #1430

Merged
merged 1 commit into from
Jan 15, 2016

Conversation

cramforce
Copy link
Member

The default continues to be to infer the size from the size of the ad slot.

Closes #1429

The default continues to be to infer the size from the size of the ad slot.

Closes ampproject#1429
@ampsauce
Copy link

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: c067a4f
Build details: https://travis-ci.org/ampsauce/amphtml/builds/102413770

(Please note that this is a fully automated comment.)

@ampsauce
Copy link

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: ac3a52f597e88053eb2bf70164a4a7a8334d6891
Build details: https://travis-ci.org/ampsauce/amphtml/builds/102413392

(Please note that this is a fully automated comment.)

@jridgewell
Copy link
Contributor

LGTM, but I'm not sure what the utility in this is. It makes a big amp-ad block with smaller/larger content inside it?

@cramforce
Copy link
Member Author

@jridgewell This is for a special case where magic dimensions are used (like 3x3) to e.g. get ads that auto size to the container dimension.

cramforce added a commit that referenced this pull request Jan 15, 2016
Allow DoubleClick ads to explicitly request an ad size.
@cramforce cramforce merged commit 2061eed into ampproject:master Jan 15, 2016
@cramforce cramforce deleted the dfp-ad-size-override branch January 15, 2016 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants