Implement performance ticks for framerate. #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.collect(); | ||
| console.info('visible') | ||
| } else { | ||
| this.win.cancelAnimationFrame(this.requestedFrame_); |
There was a problem hiding this comment.
if (this.win.cancelAnimationFrame) {...}
There was a problem hiding this comment.
this.requestedFrame_ can also be null here. Not sure if that would be a problem here.
|
Looks good. I think just couple of reset conditions need fixing. |
| * to avoid having to request and cancel all the time. | ||
| * @private {boolean} | ||
| */ | ||
| this.frameScheduled_ = false; |
There was a problem hiding this comment.
Can't we just use this.requestedFrame_ != null?
|
This is now ready for review. |
|
LGTM on my side. Leaving final LGTM to @erwinmombay |
| this.reset_(); | ||
| this.collect(); | ||
| } else { | ||
| this.reset_(); |
There was a problem hiding this comment.
You can remove the else conditional. Always #reset_, and call #collect if isActive_.
|
@cramforce LGTM, pending @jridgewell recommendation |
Calculates the rate by counting animation frames over a timespan. We only measure when we rendered an element or the user scrolled, and then for 5 seconds. This is basically a heuristic for "something interesting might be happening". Otherwise on mostly empty pages the framerate is always 60fps.
cramforce
added a commit
that referenced
this pull request
Jan 16, 2016
Implement performance ticks for framerate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculates the rate by counting animation frames over a timespan.
We only measure when we rendered an element or the user scrolled, and then for 5 seconds. This is basically a heuristic for "something interesting might be happening". Otherwise on mostly empty pages the framerate is always 60fps.