Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gulpfile): fix some copy race conditions. #1363

Closed
wants to merge 1 commit into from
Closed

fix(gulpfile): fix some copy race conditions. #1363

wants to merge 1 commit into from

Conversation

erwinmombay
Copy link
Member

No description provided.

@dvoytenko
Copy link
Contributor

LGTM

@erwinmombay
Copy link
Member Author

@dvoytenko haven't fixed it fully yet. haven't been to get the amp-login-done-0.1.max.js to be written out to dist on the gulp dist task. will keep working on it and ping you again, apologies

@erwinmombay
Copy link
Member Author

been handled in #1387 and #1394

@elijahsoria elijahsoria mentioned this pull request Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dvoytenko dvoytenko

Labels
WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erwinmombay @dvoytenko