Wait for the first authorization to complete before sending pingback #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
dvoytenko
added a commit
that referenced
this pull request
Jan 8, 2016
Wait for the first authorization to complete before sending pingback
| }); | ||
| return Promise.resolve().then(() => { | ||
| expect(resolved).to.be.false; | ||
| }); |
There was a problem hiding this comment.
This is a non-deterministic test. It'd be better to return the service.firstAuthorizationPromise_ like:
return service.firstAuthorizationPromise_.then(() => {
throw new Error('should not have resolved');
}, () => {
assert(true);
});There was a problem hiding this comment.
Should be correct in the micro-task order, no? The issue here is that it's supposed to be never resolved - this would crash the test with timeout.
There was a problem hiding this comment.
Ah, see #1350 (comment). A rejected promise never fulfills, fixing the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.