Fix 2 edge cases in ad viewability #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cramforce
commented
Jan 6, 2016
cramforce
commented
- The switch from viewport change to the more frequent scroll dropped sending events on resize.
- Also send changes on remeasure, as our size might have changed for some reason.
1. The switch from viewport change to the more frequent scroll dropped sending events on resize. 2. Also send changes on remeasure, as our size might have changed for some reason.
cramforce
force-pushed
the
viewability-resize
branch
from
837091f to
b018e56
Compare
|
@sriramkrish85 Please review. You'll need to merge this :/ |
|
@cramforce did you want me to merge this PR to master (or did you intend to say that i would have merge this into my viewability info PR) |
|
@sriramkrish85 Just wanted to give you a heads up that you'd likely would need to merge these changes in your PR. Just need a standard review here. |
|
LGTM |
cramforce
added a commit
that referenced
this pull request
Jan 7, 2016
Fix 2 edge cases in ad viewability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.