Set up Greenkeeper GH_TOKEN for PR builds #12807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @erwinmombay |
erwinmombay
approved these changes
Jan 11, 2018
|
First version didn't work: https://travis-ci.org/ampproject/amphtml/jobs/327881026#L589 Trying |
|
Seems like it worked: https://travis-ci.org/ampproject/amphtml/jobs/327916084#L667 |
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JWT token we were using earlier does not work for PR builds. Therefore, we were seeing a permission error: https://travis-ci.org/ampproject/amphtml/jobs/327380341#L808
This PR decodes a previously set GH token with just the
public_repopermission, for use bygreenkeeper-lockfile-upload.Follow up to #12683 #12720 #12732 #12789 #12791
Unblocks #12766
Partial fix for #1218