Calculate correct documentHeight for short AMP docs #12229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterjosling
force-pushed
the
short_document_fix
branch
from
bd4561f to
8583b43
Compare
peterjosling
force-pushed
the
short_document_fix
branch
from
8583b43 to
167e5b2
Compare
jridgewell
requested changes
Nov 29, 2017
| // Body is overflow: hidden so that the scrollHeight include the margins of | ||
| // body's first and last child. | ||
| const rect = this.win.document.body./*OK*/getBoundingClientRect(); | ||
| return rect.height + rect.top + this.getScrollTop(); |
There was a problem hiding this comment.
Can you confirm what this does? Why would scroll top be needed here?
There was a problem hiding this comment.
Updated the comment to clarify.
I couldn't think of a better way to get the scrollTop back out of the DOM - offsetTop for the body is zero, and reading paddingTop out of the html element's style is messy. Alternatively could store paddingTop when setPaddingTop() is called and add it on here? This method is more generic though - would work with e.g. marginTop on body instead of paddingTop on html.
peterjosling
force-pushed
the
short_document_fix
branch
from
fd20ae0 to
98276f9
Compare
added 2 commits
December 4, 2017 11:34
Handles the edge case of AMP documents which are shorter than their containing viewport, which causes documentHeight to be scrollHeight, which is the height of the viewport. Should be a no-op for docs which are already taller than the viewport. Re-implements changes made in ampproject@ac741f6, which were reverted before merging.
Non-HTML5 doctype has different behaviour for html/body element heights in Safari.
peterjosling
force-pushed
the
short_document_fix
branch
from
98276f9 to
fbd0cf8
Compare
jridgewell
approved these changes
Dec 4, 2017
ghost
pushed a commit
that referenced
this pull request
Dec 6, 2017
* Use contentHeight for documentHeight messages Handles the edge case of AMP documents which are shorter than their containing viewport, which causes documentHeight to be scrollHeight, which is the height of the viewport. Should be a no-op for docs which are already taller than the viewport. Re-implements changes made in ac741f6, which were reverted before merging. * Use HTML5 doctype for RealWinFixture Non-HTML5 doctype has different behaviour for html/body element heights in Safari.
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* Use contentHeight for documentHeight messages Handles the edge case of AMP documents which are shorter than their containing viewport, which causes documentHeight to be scrollHeight, which is the height of the viewport. Should be a no-op for docs which are already taller than the viewport. Re-implements changes made in ampproject@ac741f6, which were reverted before merging. * Use HTML5 doctype for RealWinFixture Non-HTML5 doctype has different behaviour for html/body element heights in Safari.
This was referenced Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles the edge case of AMP documents which are shorter than their
containing viewport, which causes documentHeight to be scrollHeight,
which is the height of the viewport. Should be a no-op for docs which
are already taller than the viewport.
Re-implements changes made in ac741f6, which were reverted before merging.
Fixes #12172