Make early loaded extensions load robust against errors in individual extensions #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
force-pushed
the
extension-load-exceptions
branch
from
1a9c664 to
7eb67b0
Compare
… extensions, so that an error in A does not prevent B from loading. Fixes ampproject#1159 Also adds tests for runtime.js
cramforce
force-pushed
the
extension-load-exceptions
branch
from
7eb67b0 to
c89abb1
Compare
| } catch (e) { | ||
| // Throw errors outside of loop in its own micro task to | ||
| // avoid on error stopping other extensions from loading. | ||
| timer.delay(() => {throw e;}, 1); |
cramforce
added a commit
that referenced
this pull request
Dec 16, 2015
Make early loaded extensions load robust against errors in individual extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that an error in A does not prevent B from loading.
Fixes #1159
Also adds tests for runtime.js