Adds amp-analytics support for 'click' events. #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if (eventType === AnalyticsEventType.CLICK) { | ||
| this.ensureClickListener_(); | ||
| this.clickObservable_.add( | ||
| this.createSelectiveListener_(listener, opt_selector)); |
There was a problem hiding this comment.
What would an empty/undefined/null opt_selector mean in this case? Should there be some check to require it or issue a warning?
There was a problem hiding this comment.
An unspecified opt_selector indicates the trigger will fire on any click event (regardless of target).
There was a problem hiding this comment.
Updated so that we never fire the click listener if the selector is null.
btownsend
force-pushed
the
analytics-clicks
branch
from
1b4267e to
9c5636f
Compare
|
Updated with feedback. This is now ready for review. |
btownsend
force-pushed
the
analytics-clicks
branch
from
9c5636f to
d7dc485
Compare
|
LGTM |
dvoytenko
added a commit
that referenced
this pull request
Dec 16, 2015
Adds amp-analytics support for 'click' events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at adding support for firing amp-analytics requests in response to click events, with support for selectors.
@dvoytenko I'd like to get feedback on this approach before adding tests. In particular how I should handle event dispatching in a performance-friendly way (not sure the current vsync'ing on each observer is helpful.)