Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amp-story spec #11484

Merged
merged 3 commits into from
Oct 2, 2017
Merged

Add amp-story spec #11484

merged 3 commits into from
Oct 2, 2017

Conversation

newmuis
Copy link
Contributor

@newmuis newmuis commented Sep 29, 2017

This adds the spec for the amp-story extension. The implementation is being committed in parallel.

/cc @dvoytenko

@dreamofabear dreamofabear requested a review from a user September 29, 2017 15:56
@dreamofabear
Copy link

I don't think we include static assets for examples in the extension folders (so far). Some extensions have embedded examples that loads a page from a Firebase app via amp-iframe (e.g. amp-accordion).

/to @bpaduch For the best practice here and docs review.

@ghost
Copy link

ghost commented Sep 29, 2017

Re: images in extensions folder - Haven't seen other extensions include images in the extension's folder and I would suspect you'd want to keep the extension code folder clean itself. In the Building an Extension doc, they suggest creating an example, so I'd recommend storying those images in https://github.com/ampproject/amphtml/tree/master/examples/img there and linking to them.

Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving them to ABE is also an option. Feel free to do that post-merge.

<script async src="https://stamp-prototype.appspot.com/v0.js"></script>
<script async custom-element="amp-story"
src="https://stamp-prototype.appspot.com/v0/amp-story-0.1.js"></script>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update these to AMP Cache URLs.

# <a name="`amp-story`"></a> `amp-story`

**THIS IS EXPERIMENTAL AND UNDER ACTIVE DEVELOPMENT!!**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most AMP extensions start with a <table> here containing a description, required script, status, and links to examples, etc. See others for example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #11530

@alanorozco alanorozco merged commit 8e3e95f into ampproject:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants