Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow data: URLs. #1118

Merged
merged 1 commit into from
Dec 9, 2015
Merged

Disallow data: URLs. #1118

merged 1 commit into from
Dec 9, 2015

Conversation

Gregable
Copy link
Member

@Gregable Gregable commented Dec 9, 2015

Also some cleanups on the validator error messages.

Also some cleanups on the validator error messages.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Gregable
Copy link
Member Author

Gregable commented Dec 9, 2015

I signed it!

@Gregable Gregable closed this Dec 9, 2015
@Gregable Gregable reopened this Dec 9, 2015
@dvoytenko dvoytenko added the LGTM label Dec 9, 2015
@dvoytenko dvoytenko self-assigned this Dec 9, 2015
@dvoytenko
Copy link
Contributor

LGTM

dvoytenko added a commit that referenced this pull request Dec 9, 2015
@dvoytenko dvoytenko merged commit 1277d03 into ampproject:master Dec 9, 2015
@Gregable Gregable deleted the dataurl branch June 20, 2016 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants