Updates amp-analytics with support for expanding config/trigger vars. #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
CLA should already be signed. |
|
CLAs look good, thanks! |
| @@ -24,3 +24,33 @@ export function dashToCamelCase(name) { | |||
| return character.toUpperCase(); | |||
| }); | |||
| } | |||
|
|
|||
| /** | |||
| * Expands place holders in a given template string with values. | |||
|
Thanks! I think this looks good. Just a few comments. |
|
Updated to address feedback. |
|
LGTM. Could you please squash commits? |
This also changes the place holder syntax for analytics request template
strings to ${id} (instead of {id}) for consistency with ES6 template strings.
|
Squashed. |
dvoytenko
added a commit
that referenced
this pull request
Dec 10, 2015
Updates amp-analytics with support for expanding config/trigger vars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for expanding place holders in amp-analytics request template strings with values specified in amp-analytics trigger vars and config vars. This also changes the place holder syntax to ${id} (instead of {id}) for consistency with ES6 template strings.