Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(amp-ad): remove backfill code from amp-ad #1091

Merged
merged 1 commit into from
Dec 10, 2015

Conversation

erwinmombay
Copy link
Member

Closes #1088

@erwinmombay erwinmombay self-assigned this Dec 7, 2015
@ampsauce
Copy link

ampsauce commented Dec 7, 2015

Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED

Commit: a6e473ad2ebad31d202b758fa9a0b27987759c45
Build details: https://travis-ci.org/ampsauce/amphtml/builds/95453036

(Please note that this is a fully automated comment.)

@erwinmombay erwinmombay assigned cramforce and unassigned erwinmombay Dec 7, 2015
@erwinmombay erwinmombay changed the title [WIP] refactor(amp-ad): remove backfill code from amp-ad refactor(amp-ad): remove backfill code from amp-ad Dec 7, 2015
@erwinmombay
Copy link
Member Author

/cc @dvoytenko

@cramforce
Copy link
Member

LGTM

erwinmombay added a commit that referenced this pull request Dec 10, 2015
refactor(amp-ad): remove backfill code from amp-ad
@erwinmombay erwinmombay merged commit 80c983d into ampproject:master Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants