Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): make sure to flush once the perf functions are set #1077

Merged
merged 1 commit into from
Dec 4, 2015

Conversation

erwinmombay
Copy link
Member

the runtime sometimes executes a call to flush earlier than the actual viewer forwarding code is set.

@@ -150,6 +150,7 @@ export class Performance {
this.tick_ = tick;
this.flush_ = opt_flush;
this.flushQueuedTicks_();
this.flush();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment to this block of code.

@cramforce
Copy link
Member

LGTM with comment

@erwinmombay erwinmombay assigned cramforce and unassigned dvoytenko Dec 4, 2015
erwinmombay added a commit that referenced this pull request Dec 4, 2015
fix(perf): make sure to flush once the perf functions are set
@erwinmombay erwinmombay merged commit a023d54 into ampproject:master Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants