AMP boilerplate changes to be done after validator changes to suppor… #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might make sense to also create a corresponding issue in the docs repo to update the docs/samples over there |
camelburrito
force-pushed
the
boilerplate
branch
4 times, most recently
from
ff00b04 to
221f938
Compare
camelburrito
force-pushed
the
boilerplate
branch
from
221f938 to
e553d3e
Compare
| @@ -23,7 +23,7 @@ | |||
| padding-bottom: 75vh; | |||
| } | |||
| </style> | |||
| <style>body {opacity: 0}</style><noscript><style>body {opacity: 1}</style></noscript> | |||
| <style amp-boilerplate>body{-webkit-animation:-amp-start 1s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 1s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 1s steps(1,end) 0s 1 normal both;animation:-amp-start 1s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript> | |||
There was a problem hiding this comment.
I just wanted to clarify my understanding: We decided on a 1s timeout?
There was a problem hiding this comment.
Hmm. Wasn't it 3 seconds?
camelburrito
force-pushed
the
boilerplate
branch
3 times, most recently
from
a27bfbb to
80cacec
Compare
|
PTAL |
camelburrito
force-pushed
the
boilerplate
branch
from
80cacec to
d7a31f4
Compare
…t the new boilerplate code is in.
camelburrito
force-pushed
the
boilerplate
branch
from
d7a31f4 to
0a056ca
Compare
|
PTAL |
cramforce
changed the title
cramforce
changed the title
|
LGTM |
|
Fixes #323. |
camelburrito
pushed a commit
that referenced
this pull request
Feb 2, 2016
AMP boilerplate changes to be done after validator changes to suppor…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amp Boiler plate changes to be done after validator changes to support the new boilerplate code is in.