Fix risk condition on loading indicator when layout completes before vsync. #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1002,6 +1002,28 @@ describe('CustomElement Loading Indicator', () => { | |||
| expect(toggle.firstCall.args[1]).to.equal(true); | |||
| }); | |||
| }); | |||
|
|
|||
| it('should ignore loading on if layout completed before vsync', () => { | |||
There was a problem hiding this comment.
It's loading "on" :)
| @@ -305,6 +305,9 @@ export function createAmpElementProto(win, name, implementationClass) { | |||
| /** @private {boolean|undefined} */ | |||
| this.loadingDisabled_; | |||
|
|
|||
| /** @private {boolean|undefined} */ | |||
| this.loadingState_; | |||
There was a problem hiding this comment.
is it possible to to start with a boolean state? like false by default?
There was a problem hiding this comment.
To be stripped out by a compiler.
|
LGTM. |
dvoytenko
added a commit
that referenced
this pull request
Dec 1, 2015
Fix risk condition on loading indicator when layout completes before vsync.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.