-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic fullscreen videos on device roation #10108
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dbc7053
Started working on the rotate to fullscreen
wassgha 2349f02
Implemented enterFullscreen and exitFullscreen for all video players …
wassgha 0a568d3
Requested changes for auto-fullscreen
wassgha d8478d4
Added isFullscreen method to the video interface, fixes bugs with Chr…
wassgha 6f76e18
Requested changes
wassgha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Requested changes
- Loading branch information
commit 6f76e185ad4f01502febb1f072642540b89c893a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return early if
this.loaded_
isfalse
. What can happen is orientation change occurring before thelayoutCallback
of a video player is called in which case theiriframe
is null. Now at the moment we can't get to that case because of thethis.getPlayingState() == PlayingStates.PLAYING_MANUAL
check but I like to keep the code safe since later supporting AUTOPLAY can surface the race condition.