Add Vine HTML component #1006
Merged
Add Vine HTML component #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import {isLayoutSizeDefined} from '../../../src/layout'; | ||
| import {loadPromise} from '../../../src/event-helper'; | ||
|
|
||
| class AmpVine extends AMP.BaseElement { |
There was a problem hiding this comment.
add newline between class declaration an and first method.
|
Looks great! just some minor recommendations and will LGTM. |
|
@niallkennedy also feel free to add yourself to CONTRIBUTORS |
|
@erwinmombay outstanding requests should have been met with 4072da7 |
|
LGTM |
|
@cramforce should we be updating the validator in this PR too for the |
|
@erwinmombay I think we aren't there yet. Maybe ping @powdercloud on chat. |
|
@niallkennedy just one request, do you mind squashing this into 1 commit. thanks! will merge right after |
|
@cramforce my mistake, its already in the protoascii definition. |
|
@erwinmombay squashed into eb98861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
amp-vinecustom element. Pause video through inactive callback.Includes example file, automated tests, and manual test file.
Intent to implement issue: #1005