Refactored vsync for animations and non-animations uses #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,13 +160,11 @@ export class FontLoader { | |||
| } else if (this.compareMeasurements_()) { | |||
| resolve(); | |||
| } else { | |||
| vsync.run(vsyncTask); | |||
There was a problem hiding this comment.
do we still want to expose run as public if createTask is the preferred interface?
There was a problem hiding this comment.
For now, yes. run - one time call. createTask - repeated calls. This way they are easy to tell apart.
|
LGTM, minor nits. |
dvoytenko
added a commit
that referenced
this pull request
Nov 25, 2015
Refactored vsync for animations and non-animations uses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vsync now has two sets of APIs: one for animation cases and one for all others. The animation cases are protected from running when document is not visible. Non-animation cases are forced to run even when document is not visible.
Closes #839.
/cc @sriramkrish85