Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-next-page] v1.0 not working if in first viewport #29918

Closed
noodles opened this issue Aug 20, 2020 · 4 comments
Closed

[amp-next-page] v1.0 not working if in first viewport #29918

noodles opened this issue Aug 20, 2020 · 4 comments
Labels
Component: amp-next-page Customer: MSC Mobile Solution Consultants P2: Soon Type: Bug Type: UX issues impacting end user experience WG: components

Comments

@noodles
Copy link
Contributor

noodles commented Aug 20, 2020

#29855 What's the issue?

amp-next-page does not work at all if the component appears in the first viewport

next-page-demo glitch me_1_0issue html(Moto G4)

How do we reproduce the issue?

Create an AMP page with with the amp-next-page component but only add enough text/content so that the amp-next-component is visible in the first viewport.

v1.0 issue example

Adding more content to push the amp-next-page component out of the first viewport will fix the isse;

v1.0 fix example

What browsers are affected?

All browsers

@nainar
Copy link
Contributor

nainar commented Aug 23, 2020

Related #29936

@nainar nainar added Component: amp-next-page Customer: MSC Mobile Solution Consultants Type: UX issues impacting end user experience WG: components P2: Soon labels Aug 23, 2020
@dmanek
Copy link
Contributor

dmanek commented Jan 11, 2021

@nainar @wassgha this unit test https://github.com/ampproject/amphtml/blob/master/extensions/amp-next-page/1.0/test/test-amp-next-page.js#L332 leads me to believe that amp-next-page was designed to be displayed only when the user scrolls below the first viewport. Do we want to support this use case?

@wassgha
Copy link
Contributor

wassgha commented Jan 11, 2021

That's correct behavior. This is to avoid layout shift

@dmanek
Copy link
Contributor

dmanek commented Jan 11, 2021

Closing this issue as WAI.

@dmanek dmanek closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: amp-next-page Customer: MSC Mobile Solution Consultants P2: Soon Type: Bug Type: UX issues impacting end user experience WG: components
Projects
None yet
Development

No branches or pull requests

4 participants