Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌸 Cherry-pick request for #29853 into #29805 (Pending) #29855

Closed
lannka opened this issue Aug 17, 2020 · 4 comments
Closed

🌸 Cherry-pick request for #29853 into #29805 (Pending) #29855

lannka opened this issue Aug 17, 2020 · 4 comments
Assignees
@kristoferbaxter @cramforce @dreamofabear @mrjoro @estherkim
Labels
Cherry-pick: Beta Cherry-pick: Experimental Type: Release Used to track AMP releases from canary to production

Comments

@lannka
Copy link
Contributor

lannka commented Aug 17, 2020 •
edited
Loading

Cherry-pick request

Issue PR Beta / Experimental? Stable? LTS? Release issue
#29759 #29853 YES NO NO #29805

Why does this issue meet the cherry-pick criteria?

It breaks many 3p ads that wait for inViewport signal to render (e.g. play video)

Mini-postmortem

TODO: This postmortem will be written after the cherry-pick deployment and before this issue is closed. Delete this TODO when the postmortem is ready.

Summary

Impact

Action Items

/cc @ampproject/release-on-duty @ampproject/wg-approvers @ampproject/cherry-pick-approvers
@kristoferbaxter
Copy link
Contributor

Approved.

@estherkim
Copy link
Collaborator

Noted - cherry picking 2008072132002

@kristoferbaxter
Copy link
Contributor

Sent a few follow up messages to this as well, but we'd like to add some additional testing to ensure this issue is fixed as expected for more scenarios.

@calebcordry calebcordry mentioned this issue Aug 17, 2020
Closed
6 tasks
@lannka lannka mentioned this issue Aug 20, 2020
Merged
@noodles noodles mentioned this issue Aug 20, 2020
Closed
@rsimha
Copy link
Contributor

rsimha commented Dec 1, 2020

[Cleaning up old CP issues] Can this be closed?

@lannka lannka closed this as completed Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristoferbaxter kristoferbaxter

@cramforce cramforce

@dreamofabear dreamofabear

@mrjoro mrjoro

@estherkim estherkim

Labels
Cherry-pick: Beta Cherry-pick: Experimental Type: Release Used to track AMP releases from canary to production
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kristoferbaxter @cramforce @lannka @dreamofabear @mrjoro @rsimha @estherkim