-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story bot render mode: Force text to be visible #26528
Comments
Did you notice that on a specific story? We already have some CSS that should prevent this from happening, I'd be curious to see what kind of publisher provided CSS overrode it: amphtml/extensions/amp-story/1.0/amp-story-vertical.css Lines 66 to 68 in 0b9623c
|
Interesting. I thought I saw it, but I must have been mistaken. Will keep an eye out for it! |
One tiny change: Should we made |
Otherwise the padding leads to the text going over the edge of the right side of the screen. Fixes ampproject#26528
Otherwise the padding leads to the text going over the edge of the right side of the screen. Fixes #26528
The text inferred from slide titles and video alt attributes should be forced to be readable.
This could e.g. be achieved by setting the background color of the text and the color of the text to different, high contrast colors. Today it can happen that a story e.g. sets a white background color and a white text color which works, because the text is usually not shown directly over the page background.
The text was updated successfully, but these errors were encountered: