Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling does not contribute to engaged time on mobile devices #2226

Closed
britice opened this issue Feb 23, 2016 · 6 comments
Closed

Scrolling does not contribute to engaged time on mobile devices #2226

britice opened this issue Feb 23, 2016 · 6 comments

Comments

@britice
Copy link

britice commented Feb 23, 2016

PR #1818 was intended to capture overall engagement with articles by users across any viewing platform. One action which should contribute to a measure of user engagement is the 'scroll' event.

A scroll event listener is being registered by the Activity service in an attempt to include that activity in the engaged time measurement. However, in testing in mobile devices since the feature was released, scrolling in the device does not contribute to engaged time.

@britice
Copy link
Author

britice commented Feb 23, 2016

I think I figured it out already. The scroll event listener is being registered on document.documentElement rather than on the document. I'll need to modify how this is being set up.

@cramforce
Copy link
Member

@britice use viewer.onScroll. That will give you scroll events independent of our various platform specific scrolling implementations.

@britice
Copy link
Author

britice commented Feb 23, 2016

Oh perfect.

@britice
Copy link
Author

britice commented Feb 23, 2016

@cramforce, did you mean viewport.onScroll instead of viewer.onScroll? I don't see that method available on the Viewer class.

Or were you suggesting to use viewer.onViewportEvent?

@cramforce
Copy link
Member

Sorry, viewport is correct.

On Tue, Feb 23, 2016 at 10:10 AM, Brian Tice notifications@github.com
wrote:

@cramforce https://github.com/cramforce, did you mean viewport.onScroll
instead of viewer.onScroll? I don't see that method available on the
Viewer class.

Or were you suggesting to use viewer.onViewportEvent?


Reply to this email directly or view it on GitHub
#2226 (comment)
.

@ericlindley-g
Copy link
Contributor

Closing, as this looks like it's resolved, but @britice, please feel free to reopen if there are any outstanding issues/questions!

keevcodes added a commit to keevcodes/amphtml that referenced this issue May 8, 2019
all files in the validator folder referencing ampproject.org will be handled by the validator team ampproject#2226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants