Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for additional substitution variables in amp-analytics #1503

Closed
5 tasks
rudygalfi opened this issue Jan 21, 2016 · 4 comments
Closed
5 tasks

Support for additional substitution variables in amp-analytics #1503

rudygalfi opened this issue Jan 21, 2016 · 4 comments
Assignees
@avimehta
Labels
Type: Feature Request WG: analytics

Comments

@rudygalfi
Copy link
Contributor

suggested by @msukmanowsky:

  • availScreenWidth = screen.availWidth
  • availScreenHeight = screen.availHeight
  • colorDepth = screen.colorDepth

suggested by @avimehta:

  • documentEncoding
  • userLanguage
@rudygalfi rudygalfi mentioned this issue Jan 21, 2016
Closed
@avimehta
Copy link
Contributor

@rudygalfi Add the analytics tag here? Also maybe make this a tracking bug of all the variables we need to add to amp-analytics? I have a couple of vars of my own that GA would like to add: documentEncoding and userLanguage.

@avimehta avimehta mentioned this issue Jan 25, 2016
Merged
@rudygalfi rudygalfi changed the title Support for availScreenWidth, availScreenHeight, and colorDepth in amp-analytics Support for additional substitution variables in amp-analytics Jan 25, 2016
@rudygalfi
Copy link
Contributor Author

@avimehta Added the suggested vars at the top of the issue.

@avimehta
Copy link
Contributor

if @msukmanowsky is working on this, that is great. If not, I can take this up.

@msukmanowsky
Copy link
Contributor

Not tackling this one any time soon @avimehta, sorry.

@rudygalfi rudygalfi assigned avimehta and unassigned msukmanowsky Jan 26, 2016
@avimehta avimehta mentioned this issue Jan 27, 2016
Merged
@avimehta avimehta mentioned this issue Jan 29, 2016
Merged
avimehta added a commit to avimehta/amphtml that referenced this issue Jan 29, 2016
@avimehta
Added additional amp-analytics vars.
b70f63a 
New vars: available screen width, available screen height, color depth,
document encoding and user language.

Fixes ampproject#1503
@qidonna qidonna mentioned this issue Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avimehta avimehta

Labels
Type: Feature Request WG: analytics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avimehta @msukmanowsky @rudygalfi