Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate amp-analytics from experimental #1485

Closed
rudygalfi opened this issue Jan 20, 2016 · 5 comments
Closed

Graduate amp-analytics from experimental #1485

rudygalfi opened this issue Jan 20, 2016 · 5 comments
Assignees
@avimehta
Labels
WG: analytics

Comments

@rudygalfi
Copy link
Contributor

Remove code for experiment to make the feature enabled by default.
avimehta added a commit to avimehta/amphtml that referenced this issue Jan 20, 2016
@avimehta
Removed experiment flag from amp-analytics. ampproject#1485
ef11aa8 
Also fixed a link related to GA. The link is still not live.
cramforce added a commit that referenced this issue Jan 20, 2016
@cramforce
Merge pull request #1487 from avimehta/exp
48960d5 
Removed experiment flag from amp-analytics. #1485
@rudygalfi
Copy link
Contributor Author

Fixed by #1487

@rudygalfi rudygalfi mentioned this issue Jan 20, 2016
Closed
@rudygalfi
Copy link
Contributor Author

Did we need to remove from https://cdn.ampproject.org/experiments.html as part of this?

cc @dvoytenko

@dvoytenko
Copy link
Contributor

Yes. This should have been done in the same PR. Obviously now it needs to be completed.

@dvoytenko dvoytenko reopened this Jan 21, 2016
@avimehta
Copy link
Contributor

will send out another PR.

avimehta added a commit to avimehta/amphtml that referenced this issue Jan 21, 2016
@avimehta
Remove amp-analytics from experiments list. ampproject#1485
4e4cb0e
dvoytenko added a commit that referenced this issue Jan 21, 2016
@dvoytenko
Merge pull request #1504 from avimehta/patch-1
f3d1ecd 
Remove amp-analytics from experiments list. #1485
msukmanowsky pushed a commit to Parsely/amphtml that referenced this issue Jan 21, 2016
@avimehta @msukmanowsky
Removed experiment flag from amp-analytics. ampproject#1485
1337091 
Also fixed a link related to GA. The link is still not live.
msukmanowsky pushed a commit to Parsely/amphtml that referenced this issue Jan 21, 2016
@avimehta @msukmanowsky
Remove amp-analytics from experiments list. ampproject#1485
58d43b8
@rudygalfi
Copy link
Contributor Author

Latest issue resolved by #1504.

@stellachui stellachui mentioned this issue Feb 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avimehta avimehta

Labels
WG: analytics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avimehta @dvoytenko @rudygalfi