-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule that ads need to report the creative they loaded to page #1357
Comments
👍 was there dialogue elsewhere about this? was just looking into an issue with regards to this. |
@ds0001 No real discussion. We were just looking into our performance measurements and throught it would be nice to add this info as one dimension. @rudygalfi Would be interesting to also add this to general analytics. My issue was meant to mostly address our internal perf statistics. |
@cramforce ah got it then I will 👎 to net out my vote :) |
@ds0001 Were you looking to get it into analytics? I think that is a great idea. This ticket is mostly about making the info available to the page. We can then report it to all places we'd like :) |
Agree that having the perf data related to analytics would be great too. @cramforce Could you clarify how you see the rule being enforced for both the ads and analytics cases? For analytics, would the reporting be at the level of specific measurements or events, a specific endpoint the data is getting sent to, something else? |
The rule will just be a sentence in our docs. We enforce through code review. Analytics could gather the results and make them available as a variable for reporting. |
… to the document and mandates it being called for future ad integrations. Calls it from DoubleClick. Fixes ampproject#1357
… to the document and mandates it being called for future ad integrations. Calls it from DoubleClick. Fixes ampproject#1357
We want to use this to enable attribution of runtime performance to the loaded ads.
The text was updated successfully, but these errors were encountered: