Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule that ads need to report the creative they loaded to page #1357

Closed
cramforce opened this issue Jan 8, 2016 · 6 comments
Closed

Add rule that ads need to report the creative they loaded to page #1357

cramforce opened this issue Jan 8, 2016 · 6 comments

Comments

@cramforce
Copy link
Member

We want to use this to enable attribution of runtime performance to the loaded ads.

@cramforce cramforce self-assigned this Jan 8, 2016
@ds0001
Copy link

ds0001 commented Jan 8, 2016

👍 was there dialogue elsewhere about this? was just looking into an issue with regards to this.

@cramforce
Copy link
Member Author

@ds0001 No real discussion. We were just looking into our performance measurements and throught it would be nice to add this info as one dimension.

@rudygalfi Would be interesting to also add this to general analytics. My issue was meant to mostly address our internal perf statistics.

@ds0001
Copy link

ds0001 commented Jan 8, 2016

@cramforce ah got it then I will 👎 to net out my vote :)

@cramforce
Copy link
Member Author

@ds0001 Were you looking to get it into analytics? I think that is a great idea. This ticket is mostly about making the info available to the page. We can then report it to all places we'd like :)

@rudygalfi
Copy link
Contributor

Agree that having the perf data related to analytics would be great too.

@cramforce Could you clarify how you see the rule being enforced for both the ads and analytics cases?

For analytics, would the reporting be at the level of specific measurements or events, a specific endpoint the data is getting sent to, something else?

@cramforce
Copy link
Member Author

The rule will just be a sentence in our docs. We enforce through code review.

Analytics could gather the results and make them available as a variable for reporting.

cramforce added a commit to cramforce/amphtml that referenced this issue Jan 8, 2016
… to the

document and mandates it being called for future ad integrations.
Calls it from DoubleClick.

Fixes ampproject#1357
msukmanowsky pushed a commit to Parsely/amphtml that referenced this issue Jan 21, 2016
… to the

document and mandates it being called for future ad integrations.
Calls it from DoubleClick.

Fixes ampproject#1357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants