Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change buildFromJson to return an empty array on undefined input #11549

Closed
newmuis opened this issue Oct 3, 2017 · 0 comments
Closed

Change buildFromJson to return an empty array on undefined input #11549

newmuis opened this issue Oct 3, 2017 · 0 comments
Assignees
@alanorozco
Labels
WG: stories
Milestone
Pending Triage

Comments

@newmuis
Copy link
Contributor

newmuis commented Oct 3, 2017

This will allow us to remove the ternary check in amp-story.js (introduced in #11511).
@newmuis newmuis mentioned this issue Oct 3, 2017
Merged
@ampprojectbot ampprojectbot added this to the Pending Triage milestone Oct 9, 2017
alanorozco added a commit to alanorozco/amphtml that referenced this issue Oct 10, 2017
@alanorozco
Fix ampproject#11549
928fbbb
alanorozco added a commit to alanorozco/amphtml that referenced this issue Oct 10, 2017
@alanorozco
Fix ampproject#11549
3d07537
alanorozco added a commit to alanorozco/amphtml that referenced this issue Oct 10, 2017
@alanorozco
Fix ampproject#11549
3ccee6a
neko-fire pushed a commit to 3qnexx/amphtml that referenced this issue Nov 17, 2017
@alanorozco @neko-fire
Fix ampproject#11549 to remove ugly ternary (ampproject#11630)
41b4d16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanorozco alanorozco

Labels
WG: stories
Projects
None yet
Milestone
Pending Triage
Development

No branches or pull requests
3 participants
@alanorozco @newmuis @ampprojectbot