Merge pull request #1147 from powdercloud/amp-list-test

Make the amp_list test a tad nicer. Earlier I had mistyped width,
ampproject · Dec 11, 2015 · d9955c5 · d9955c5
2 parents ea09b4b + 79e1c0f
commit d9955c5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/validator/testdata/feature_tests/amp_list.html b/validator/testdata/feature_tests/amp_list.html
@@ -32,8 +32,13 @@
             src="https://data.com/articles.json?ref=CANONICAL_URL">
     <div></div>
   </amp-list>
-  <!-- Invalid: src attribute is missing. -->
-  <amp-list wdith=10 height=10>
+  <!-- Invalid: width is mistyped. -->
+  <amp-list src="https://data.com/articles.json?ref=CANONICAL_URL"
+            wdith=10 height=10>
+    <div></div>
+  </amp-list>
+  <!-- Invalid: src is missing. -->
+  <amp-list width=10 height=10>
     <div></div>
   </amp-list>
   <!-- also invalid: width/height missing, so it's container layout

diff --git a/validator/testdata/feature_tests/amp_list.out b/validator/testdata/feature_tests/amp_list.out
@@ -1,3 +1,4 @@
 FAIL
 feature_tests/amp_list.html:36:2 DISALLOWED_ATTR wdith (see https://github.com/ampproject/amphtml/blob/master/extensions/amp-list/amp-list.md)
-feature_tests/amp_list.html:41:2 IMPLIED_LAYOUT_INVALID layout CONTAINER not supported (see https://github.com/ampproject/amphtml/blob/master/extensions/amp-list/amp-list.md)
+feature_tests/amp_list.html:41:2 MANDATORY_ATTR_MISSING src (see https://github.com/ampproject/amphtml/blob/master/extensions/amp-list/amp-list.md)
+feature_tests/amp_list.html:46:2 IMPLIED_LAYOUT_INVALID layout CONTAINER not supported (see https://github.com/ampproject/amphtml/blob/master/extensions/amp-list/amp-list.md)