Skip to content

Commit

Permalink
📦 Update dependency gulp-prettier to v3 (#27349)
Browse files Browse the repository at this point in the history
* 📦 Update dependency gulp-prettier to v3

* Fix all non-JS files with Prettier v2

Co-authored-by: Raghu Simha <rsimha@amp.dev>
  • Loading branch information
renovate-bot and rsimha authored Mar 30, 2020
1 parent 00aff59 commit 7163971
Show file tree
Hide file tree
Showing 36 changed files with 5,689 additions and 1,259 deletions.
12 changes: 6 additions & 6 deletions ads/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ The API allows you to specify a callback that fires with change records when AMP
_Example usage_:

```javascript
window.context.observeIntersection(function(changes) {
changes.forEach(function(c) {
window.context.observeIntersection(function (changes) {
changes.forEach(function (c) {
console.info('Height of intersection', c.intersectionRect.height);
});
});
Expand All @@ -125,8 +125,8 @@ window.context.observeIntersection(function(changes) {
_Example usage_

```javascript
var unlisten = window.context.observeIntersection(function(changes) {
changes.forEach(function(c) {
var unlisten = window.context.observeIntersection(function (changes) {
changes.forEach(function (c) {
console.info('Height of intersection', c.intersectionRect.height);
});
});
Expand Down Expand Up @@ -169,7 +169,7 @@ The `opt_hasOverflow` is an optional boolean value, ads can specify `opt_hasOver
_Example:_

```javascript
var unlisten = window.context.onResizeSuccess(function(
var unlisten = window.context.onResizeSuccess(function (
requestedHeight,
requestedWidth
) {
Expand All @@ -178,7 +178,7 @@ var unlisten = window.context.onResizeSuccess(function(
// check which size change the request corresponds to.
});

var unlisten = window.context.onResizeDenied(function(
var unlisten = window.context.onResizeDenied(function (
requestedHeight,
requestedWidth
) {
Expand Down
17 changes: 10 additions & 7 deletions ads/pulsepoint.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,16 @@ limitations under the License.
## Header Bidding Tag Example

```html
<amp-ad width=width="300" height="250"
type="pulsepoint"
data-pid="521732"
data-tagid="76835"
data-tagtype="hb"
data-timeout="1000"
data-slot="/1066621/ExchangeTech_Prebid_AdUnit">
<amp-ad
width="300"
height="250"
type="pulsepoint"
data-pid="521732"
data-tagid="76835"
data-tagtype="hb"
data-timeout="1000"
data-slot="/1066621/ExchangeTech_Prebid_AdUnit"
>
</amp-ad>
```

Expand Down
2 changes: 1 addition & 1 deletion build-system/tasks/e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ describes.endtoend(
// By default, E2E tests run in all three environments
// environments: ['single', 'viewer-demo', 'shadow-demo']
},
env => {
(env) => {
let controller;

beforeEach(() => {
Expand Down
6 changes: 3 additions & 3 deletions contributing/building-an-amp-extension.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ class AmpMyElement extends AMP.BaseElement {
}
}

AMP.extension('amp-my-element', '0.1', AMP => {
AMP.extension('amp-my-element', '0.1', (AMP) => {
AMP.registerElement('amp-my-element', AmpMyElement, CSS);
});
```
Expand Down Expand Up @@ -288,7 +288,7 @@ AMP; all AMP extensions are prefixed with `amp-`. This is where you
tell AMP which class to use for this tag name and which CSS to load.

```javascript
AMP.extension('amp-carousel', '0.1', AMP => {
AMP.extension('amp-carousel', '0.1', (AMP) => {
AMP.registerElement('amp-carousel', CarouselSelector, CSS);
});
```
Expand Down Expand Up @@ -361,7 +361,7 @@ owners.
```javascript
this.cells_ = this.getRealChildren();

this.cells_.forEach(cell => {
this.cells_.forEach((cell) => {
Services.ownersForDoc(this.element).setOwner(cell, this.element);
cell.style.display = 'inline-block';
this.container_.appendChild(cell);
Expand Down
3 changes: 1 addition & 2 deletions contributing/getting-started-quick.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ This Quick Start guide is the TL;DR version of the longer [end-to-end guide](get
curl -o- -L https://yarnpkg.com/install.sh | bash
```

An alternative to installing `yarn` is to invoke each Yarn command in this guide with `npx yarn` during local
development. This will automatically use the current stable version of `yarn`.
An alternative to installing `yarn` is to invoke each Yarn command in this guide with `npx yarn` during local development. This will automatically use the current stable version of `yarn`.

6. If you have a global install of [Gulp](https://gulpjs.com/), uninstall it. (Instructions [here](https://github.com/gulpjs/gulp/blob/v3.9.1/docs/getting-started.md). See [this article](https://medium.com/gulpjs/gulp-sips-command-line-interface-e53411d4467) for why.)

Expand Down
12 changes: 6 additions & 6 deletions contributing/good-first-issues-template.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ Step-by-step instructions for the contributor to follow as they work through the
- [ ] Follow the instructions for [building AMP](https://github.com/ampproject/amphtml/blob/master/contributing/getting-started-e2e.md#building-amp-and-starting-a-local-server).
- [ ] [Create a Git branch](https://github.com/ampproject/amphtml/blob/master/contributing/getting-started-e2e.md#create-a-git-branch) for making your changes.
- [ ] [Sign the Contributor License Agreement](https://github.com/ampproject/amphtml/blob/master/CONTRIBUTING.md#contributor-license-agreement) before creating a Pull Request. (If you are contributing code on behalf of a corporation start this process as early as possible.)
<!--
Add steps that are specific to the issue here, e.g. perhaps they should edit a test, run `gulp unit` or `gulp integration` to see it fails, change a file and then run test again to see that the new test succeeds? Adjust the level of detail for the background you indicated the contributor should have.
-->
<!--
Add steps that are specific to the issue here, e.g. perhaps they should edit a test, run `gulp unit` or `gulp integration` to see it fails, change a file and then run test again to see that the new test succeeds? Adjust the level of detail for the background you indicated the contributor should have.
-->
- [ ] [Commit your changes](https://github.com/ampproject/amphtml/blob/master/contributing/getting-started-e2e.md#edit-files-and-commit-them) frequently.
- [ ] [Push your changes to GitHub](https://github.com/ampproject/amphtml/blob/master/contributing/getting-started-e2e.md#push-your-changes-to-your-github-fork).
<!--
Ideally suggest a reviewer for the Pull Request; not knowing who to set as the reviewer can be confusing for new contributors.
-->
<!--
Ideally suggest a reviewer for the Pull Request; not knowing who to set as the reviewer can be confusing for new contributors.
-->
- [ ] [Create a Pull Request](https://github.com/ampproject/amphtml/blob/master/contributing/getting-started-e2e.md#send-a-pull-request-ie-request-a-code-review). Mention `closes Issue <this issue number>` in the description.
- [ ] [Respond to your reviewer's comments](https://github.com/ampproject/amphtml/blob/master/contributing/getting-started-e2e.md#respond-to-pull-request-comments) (if any).

Expand Down
5 changes: 4 additions & 1 deletion examples/vega-data/bar.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@
"nice": true
}
],
"axes": [{"type": "x", "scale": "x"}, {"type": "y", "scale": "y"}],
"axes": [
{"type": "x", "scale": "x"},
{"type": "y", "scale": "y"}
],
"marks": [
{
"type": "rect",
Expand Down
Loading

0 comments on commit 7163971

Please sign in to comment.